Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (hub): add style checking workflow and reformat some files #146

Merged
merged 10 commits into from
Nov 25, 2023

Conversation

qidanrui
Copy link
Collaborator

@qidanrui qidanrui commented Nov 25, 2023

Brief Introduction of This Feature

Add style checking workflow in .github/workflows. Promise the code style when merging a PR.
Screen Shot 2023-11-25 at 6 47 06 PM

How I tested it

Test through Github. See the following "All checks have passed."

@qidanrui qidanrui added the enhancement New feature or request label Nov 25, 2023
@qidanrui qidanrui changed the title HAVEN'T TEST THE WORKFLOW, DO NOT MERGE! [feat (hub): add style checking workflow and reformat some files] feat (hub): add style checking workflow and reformat some files Nov 25, 2023
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csunny csunny merged commit 9811380 into eosphoros-ai:main Nov 25, 2023
4 checks passed
@qidanrui
Copy link
Collaborator Author

LGTM

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants