Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bird zf #205

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Feature/bird zf #205

merged 7 commits into from
Jan 2, 2024

Conversation

moutozf
Copy link
Collaborator

@moutozf moutozf commented Dec 29, 2023

Add Bird dataset data process and evaluation scripts

@qidanrui
Copy link
Collaborator

qidanrui commented Dec 29, 2023 •
edited
Loading

@moutozf I've rebased the main branch and reformatted the code style to pass through the black style checking.

qidanrui
qidanrui reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@qidanrui qidanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moutozf Hi, Fan! Thanks a lot for the contribution! Just two comments:

  • Can we still keep the default dataset here as Spider?
    Screen Shot 2023-12-29 at 7 12 15 PM

  • Does the decode_json_file part still works for Spider?
    Screen Shot 2023-12-29 at 7 13 07 PM

@wangzaistone I'm no so familiar with BIRD dataset. Could you please help me review and test the evaluation file in this PR? Thanks!

@moutozf
Copy link
Collaborator Author

moutozf commented Jan 1, 2024

@moutozf Hi, Fan! Thanks a lot for the contribution! Just two comments:

  • Can we still keep the default dataset here as Spider?
    Screen Shot 2023-12-29 at 7 12 15 PM
  • Does the decode_json_file part still works for Spider?
    Screen Shot 2023-12-29 at 7 13 07 PM

@wangzaistone I'm no so familiar with BIRD dataset. Could you please help me review and test the evaluation file in this PR? Thanks!

@qidanrui I have reset the dataset to Spider and add output name in config for decoder json file function

@qidanrui qidanrui merged commit c65d263 into eosphoros-ai:main Jan 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qidanrui qidanrui qidanrui approved these changes

@wangzaistone wangzaistone Awaiting requested review from wangzaistone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moutozf @qidanrui @zjuzf