fix(ChatKnowledge): Fix knowledge command load bug (#1767)

Co-authored-by: huangjh131 <[email protected]> Co-authored-by: Fangyin Cheng <[email protected]>
eosphoros-ai · Aug 1, 2024 · 7ea9b8c · 7ea9b8c
1 parent 25d7d94
commit 7ea9b8c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/dbgpt/app/knowledge/_cli/knowledge_client.py b/dbgpt/app/knowledge/_cli/knowledge_client.py
@@ -125,7 +125,7 @@ def knowledge_init(
     logger.info(f"Create space: {space}")
     client.space_add(space)
     logger.info("Create space successfully")
-    space_list = client.space_list(KnowledgeSpaceRequest(name=space.name))
+    space_list = client.space_list(space)
     if len(space_list) != 1:
         raise Exception(f"List space {space.name} error")
     space = KnowledgeSpaceRequest(**space_list[0])
@@ -146,7 +146,10 @@ def upload(filename: str):
                         f"Document {filename} already exist in space {space.name}, overwrite it"
                     )
                     client.document_delete(
-                        space.name, KnowledgeDocumentRequest(doc_name=filename)
+                        space.name,
+                        KnowledgeDocumentRequest(
+                            doc_name=filename, doc_type=KnowledgeType.DOCUMENT.value
+                        ),
                     )
                     doc_id = client.document_upload(
                         space.name, filename, KnowledgeType.DOCUMENT.value, filename

diff --git a/dbgpt/app/knowledge/request/request.py b/dbgpt/app/knowledge/request/request.py
@@ -16,12 +16,12 @@ class KnowledgeSpaceRequest(BaseModel):
     """name: knowledge space name"""
 
     """vector_type: vector type"""
-    id: int = None
+    id: Optional[int] = None
     name: str = None
     """vector_type: vector type"""
     vector_type: str = None
     """vector_type: vector type"""
-    domain_type: str = "normal"
+    domain_type: str = "Normal"
     """desc: description"""
     desc: str = None
     """owner: owner"""

diff --git a/dbgpt/serve/rag/service/service.py b/dbgpt/serve/rag/service/service.py
@@ -460,7 +460,7 @@ async def _sync_knowledge_document(
         )
         knowledge = None
         if not space.domain_type or (
-            space.domain_type == BusinessFieldType.NORMAL.value
+            space.domain_type.lower() == BusinessFieldType.NORMAL.value.lower()
         ):
             knowledge = KnowledgeFactory.create(
                 datasource=doc.content,