Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): .env should not build to static assets #1012

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

Aralhi
Copy link
Collaborator

@Aralhi Aralhi commented Jan 3, 2024

  • web/.env should not build to static assets
source_env=".env"
tmp_env=".env.copy"

# copy .env to a temp file
if [ -e "$source_env" ]; then
  cp "$source_env" "$tmp_env"
  rm -rf "$source_env"
else
  echo "Do not find .env"
fi

# rollback after build success.
if [ -e "$tmp_env" ]; then
  cp "$tmp_env" "$source_env" 
  rm -rf "$tmp_env"
fi

@Aralhi Aralhi requested review from csunny and fangyinc January 3, 2024 02:33
@github-actions github-actions bot added fix Bug fixes web Module: web labels Jan 3, 2024
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fangyinc fangyinc merged commit f95ce78 into main Jan 3, 2024
5 checks passed
@csunny csunny deleted the static_build_sh branch January 3, 2024 02:52
vshy108 pushed a commit to vshy108/DB-GPT that referenced this pull request Jan 18, 2024
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes web Module: web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants