Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix examples/awel default loading model text2vec-large-chinese issue #1095

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

xiuzhu9527
Copy link
Contributor

@xiuzhu9527 xiuzhu9527 commented Jan 19, 2024

Description

When I set the parameter EMBEDDING_MODEL=bge-large-zh, an error occurs when starting the service
2024-01-19 17:51:55 172-16-10-163 dbgpt.core.awel.dag.loader[5422] ERROR Failed to import: /mnt/data/xiuzhu/DB-GPT/examples/awel/simple_rag_retriever_example.py, error message: Traceback (most recent call last):
File "/mnt/data/xiuzhu/DB-GPT/dbgpt/core/awel/dag/loader.py", line 86, in parse
loader.exec_module(new_module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/mnt/data/xiuzhu/DB-GPT/examples/awel/simple_rag_retriever_example.py", line 91, in
vector_connector = _create_vector_connector()
File "/mnt/data/xiuzhu/DB-GPT/examples/awel/simple_rag_retriever_example.py", line 86, in _create_vector_connector
).create(),
File "/mnt/data/xiuzhu/DB-GPT/dbgpt/rag/embedding/embedding_factory.py", line 48, in create
return HuggingFaceEmbeddings(**new_kwargs)
File "/mnt/data/xiuzhu/DB-GPT/dbgpt/rag/embedding/embeddings.py", line 91, in init
self.client = sentence_transformers.SentenceTransformer(
File "/home/dtstack/miniconda3/envs/dbgpt_0.4.6/lib/python3.10/site-packages/sentence_transformers/SentenceTransformer.py", line 77, in init
raise ValueError("Path {} not found".format(model_name_or_path))
ValueError: Path /mnt/data/xiuzhu/models/text2vec-large-chinese not found

Close #1094

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@xiuzhu9527
Copy link
Contributor Author

issues: #1094

@xiuzhu9527
Copy link
Contributor Author

@csunny Can you help review this PR? THX!

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiuzhu9527 Thank you very much for your PR, LGTM

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit ba7248a into eosphoros-ai:main Jan 20, 2024
2 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants