Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Jina Embeddings #1105

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Jan 23, 2024

Description

I added a JinaEmbeddings class to enable the use of Jina Embeddings from their API

How Has This Been Tested?

from dbgpt.rag.embedding.embeddings import JinaEmbeddings
embs = JinaEmbeddings(api_key=<your_key>) 
ret = embs.embed_documents(['hey here', 'hey there'])
print(ret)

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2024
@csunny
Copy link
Collaborator

csunny commented Jan 23, 2024

@JoanFM Thanks for your PR, we will make a test and merge it.

Aries-ckt
Aries-ckt previously approved these changes Jan 23, 2024
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some docs?

@JoanFM
Copy link
Contributor Author

JoanFM commented Jan 23, 2024

Do we need to add some docs?

I could not find the place where to put them.

@fangyinc
Copy link
Collaborator

Do we need to add some docs?

Aha, we will update this document after the RAG document is completed.

Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 9a2b0e3 into eosphoros-ai:main Jan 24, 2024
3 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants