Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:default setting prompt with history messages #1117

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

Aries-ckt
Copy link
Collaborator

@Aries-ckt Aries-ckt commented Jan 24, 2024

Close #1116

Description

  • BufferedConversationMapperOperator
    image
  • Milvus add username and password

How Has This Been Tested?

when chat knowledge,
default setting prompt should with no history messages

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Jan 24, 2024
@fangyinc fangyinc force-pushed the fix_history_messages branch from 98bb3f3 to 703c361 Compare January 24, 2024 13:54
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit be67188 into main Jan 24, 2024
3 checks passed
@csunny csunny deleted the fix_history_messages branch March 2, 2024 14:52
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [ChatKnowledge] history message bug
3 participants