Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api path error #1165

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: api path error #1165

merged 1 commit into from
Feb 19, 2024

Conversation

lcxadml
Copy link
Collaborator

@lcxadml lcxadml commented Feb 19, 2024

Close #1160

fix bug static api path

Packaging front-end static resources caused api interface call errors, fix api path errors

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Feb 19, 2024
@lcxadml lcxadml closed this Feb 19, 2024
@lcxadml lcxadml reopened this Feb 19, 2024
Copy link
Collaborator

@Aralhi Aralhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, the api url start with / is better. 👍🏻

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 37f7ad1 into main Feb 19, 2024
9 checks passed
csunny pushed a commit to oushu1zhangxiangxuan1/DB-GPT that referenced this pull request Mar 1, 2024
@lcxadml lcxadml deleted the fix/api-path branch March 29, 2024 11:41
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Module Name] Bug in First Useing
3 participants