Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1210 : switch strategy failed in chinese env. #1219

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Aralhi
Copy link
Collaborator

@Aralhi Aralhi commented Feb 29, 2024

Fixes #1210

Description

unable to switch back to automatic mode while splitting documents in the Chinese version; however, this issue does not arise in the English version.

How Has This Been Tested?

  • Select a Chinese language environment
  • upload a document and switch to other strategy.
  • switch back to Automatic, and ui crashed.

Snapshots:

image

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@2976151305 2976151305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 58b095d into main Mar 1, 2024
7 checks passed
@csunny csunny deleted the fix/switch_strategy_error branch September 2, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants