Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix HTTP Trigger parse parameter bug #1225

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(core): Fix HTTP Trigger parse parameter bug #1225

merged 1 commit into from
Mar 1, 2024

Conversation

fangyinc
Copy link
Collaborator

@fangyinc fangyinc commented Mar 1, 2024

Description

Closes #1218

How Has This Been Tested?

  1. python examples/awel/simple_dag_example.py
  2. curl -X GET http://127.0.0.1:5555/api/v1/awel/trigger/examples/hello\?name\=zhangsan

Snapshots:

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added core Module: core fix Bug fixes labels Mar 1, 2024
csunny
csunny approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Aries-ckt
Aries-ckt approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 0e61c55 into eosphoros-ai:main Mar 1, 2024
5 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@fangyinc @Hopshine
fix(core): Fix HTTP Trigger parse parameter bug (eosphoros-ai#1225)
ea4a84f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

@Aries-ckt Aries-ckt Aries-ckt approved these changes

Assignees
No one assigned
Labels
core Module: core fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]AWEL simple_dag_example
3 participants
@fangyinc @Aries-ckt @csunny