Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance model health notifications by registering, removing, and monitoring message events. #1278

Closed
wants to merge 1 commit into from

Conversation

jsRuner
Copy link
Contributor

@jsRuner jsRuner commented Mar 12, 2024

Description

Enhance model health notifications by registering, removing, and monitoring message events.

How Has This Been Tested?

  • config .env kafka setting
  • setup dbgpt
  • add model or stop model
  • view kafka

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@fangyinc
Copy link
Collaborator

@jsRuner Thanks. But there are some issues that need to be discussed.
I think we can consider introducing an event notification interface instead of a specific implementation. And the registry is a very lightweight module and should not directly usekafka-python.

@jsRuner
Copy link
Contributor Author

jsRuner commented Mar 12, 2024

@jsRuner Thanks. But there are some issues that need to be discussed. I think we can consider introducing an event notification interface instead of a specific implementation. And the registry is a very lightweight module and should not directly usekafka-python.

@jsRuner Thanks. But there are some issues that need to be discussed. I think we can consider introducing an event notification interface instead of a specific implementation. And the registry is a very lightweight module and should not directly usekafka-python.

Okay, I'll think about it again. My original intention is to use DB-GPT as a kernel for external programs to utilize. However, the model may be in an unhealthy state, so it is more stable to determine its availability through a message queue

@jsRuner jsRuner closed this Mar 12, 2024
@jsRuner jsRuner deleted the feature-kafka branch March 20, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants