Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasource): Fix the bug of doris missing comments #1308

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix(datasource): Fix the bug of doris missing comments #1308

merged 1 commit into from
Mar 18, 2024

Conversation

lordk911
Copy link
Contributor

@lordk911 lordk911 commented Mar 18, 2024 •
edited
Loading

Description

Please ref : #1307

Changes only affect to doris type datasouce, other datasouce can overwritw get_columns method to get same solution

How Has This Been Tested?

yes, test against doris

Snapshots:

Include snapshots for easier review.

Checklist:

  • [y] My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • [y] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Aries-ckt
Aries-ckt approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc changed the title FIX:When doing DBSummary, the comments for the table column were not obtained fix(datasource): Fix the bug of doris missing comments Mar 18, 2024
@github-actions github-actions bot added the fix Bug fixes label Mar 18, 2024
fangyinc
fangyinc approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #1307

LGTM.

@fangyinc fangyinc merged commit 84bedee into eosphoros-ai:main Mar 18, 2024
5 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@lordk911 @Hopshine
fix(datasource): Fix the bug of doris missing comments (eosphoros-ai#…
1766b8f 
…1308)

Co-authored-by: shenk-b <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangyinc fangyinc fangyinc approved these changes

@Aries-ckt Aries-ckt Aries-ckt approved these changes

Assignees
No one assigned
Labels
fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordk911 @Aries-ckt @fangyinc