Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when delete knowledge, error: space list error embedding is required for MilvusStore #1359

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

xiuzhu9527
Copy link
Contributor

@xiuzhu9527 xiuzhu9527 commented Apr 1, 2024

Description

set VECTOR_STORE_TYPE=Milvus
When delete knowledge, error: space list error embedding is required for MilvusStore.

image

How Has This Been Tested?

  1. set VECTOR_STORE_TYPE=Milvus
  2. delete knowledge

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Apr 1, 2024
@xiuzhu9527
Copy link
Contributor Author

@fangyinc Can you help review this PR? THX!

@fangyinc
Copy link
Collaborator

fangyinc commented Apr 1, 2024

@fangyinc Can you help review this PR? THX!

@Aries-ckt Please review it.

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit 6210b73 into eosphoros-ai:main Apr 2, 2024
11 checks passed
@yyhhyyyyyy yyhhyyyyyy mentioned this pull request Apr 3, 2024
6 tasks
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants