Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): [chat_dashboard]Editor always run the first sql #1413

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

Aralhi
Copy link
Collaborator

@Aralhi Aralhi commented Apr 12, 2024

Description

Editor always run the first sql when i switch the sql tab.

How Has This Been Tested?

Click Run button after switch the Editor Tab, and check whether run the right sql.

Snapshots:

image

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@Aralhi Aralhi added the bug Something isn't working label Apr 12, 2024
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fangyinc fangyinc changed the title [Bug] [chat_dashboard]Editor always run the first sql fix(web): [chat_dashboard]Editor always run the first sql Apr 12, 2024
@github-actions github-actions bot added fix Bug fixes web Module: web labels Apr 12, 2024
@fangyinc fangyinc merged commit 5830093 into main Apr 12, 2024
6 checks passed
@Aralhi Aralhi deleted the fix/editor-run branch April 12, 2024 06:27
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Bug fixes web Module: web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants