Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChatData): Fix execution failure error after manually updating SQL #1812

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Hec-gitHub
Copy link
Contributor

@Hec-gitHub Hec-gitHub commented Aug 12, 2024

Closes #1668

Description

fix issue1688

How Has This Been Tested?

  1. On the New Chat page
  2. Select "Chat Data"
  3. Interacting with the database
  4. Click the "Editor" button at the top of the page
  5. Manually update SQL
  6. Click the Run button

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Update Code File:DB-GPT\web\components\chat\db-editor.tsx
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks

@fangyinc fangyinc changed the title [Chat Data]Fix execution failure error after manually updating SQL fix(ChatData): Fix execution failure error after manually updating SQL Aug 28, 2024
@github-actions github-actions bot added ChatData Module: ChatData fix Bug fixes labels Aug 28, 2024
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc merged commit 549f256 into eosphoros-ai:main Aug 28, 2024
5 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChatData Module: ChatData fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application error: a client-side exception has occurred (see the browser console for more information).
3 participants