Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat support xunfei spark ultra/max/pro/lite #2117

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Feat support xunfei spark ultra/max/pro/lite #2117

merged 4 commits into from
Nov 6, 2024

Conversation

hiyizi
Copy link
Contributor

@hiyizi hiyizi commented Nov 6, 2024 •
edited
Loading

Description

Feat support xunfei spark ultra/max/pro/lite domain

How Has This Been Tested?

test on spark ultra/max/pro/lite domain

Snapshots:

{EB3B1B8A-386A-475C-8799-5872F3A9182F}

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

csunny
csunny approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, LGTM

hiyizi
hiyizi commented Nov 6, 2024
View reviewed changes
Copy link
Contributor Author

@hiyizi hiyizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

@Aries-ckt
Copy link
Collaborator

Thank you very much for your contribution.

Aries-ckt
Aries-ckt approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aries-ckt Aries-ckt merged commit 8593f10 into eosphoros-ai:main Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

@Aries-ckt Aries-ckt Aries-ckt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiyizi @Aries-ckt @csunny