Feat feedback relations v1 #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Support score feedback 2. Add method to return topk document source
1. Support score feedback 2. Add method to return topk document source
1. Support score feedback 2. Add method to return topk document source
1. Support score feedback 2. Add method to return topk document source
fangyinc
reviewed
Sep 19, 2023
| if extra: | ||
| raise KeyError(extra) | ||
| for item_arg in used_args: | ||
| if item_arg not in set(kwargs): |
There was a problem hiding this comment.
This will have an impact on the global prompt template field verification. Can you consider the template_is_strict field of PromptTemplate to configure the prompt template to only take effect in a knowledge scene?
There was a problem hiding this comment.
Ok, I've implemented it here, #608
|
Ok, I've implemented it here, #608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: prompt manage support