Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spark conn #786

Closed
wants to merge 1 commit into from
Closed

Fix spark conn #786

wants to merge 1 commit into from

Conversation

dl-sdu
Copy link
Contributor

@dl-sdu dl-sdu commented Nov 7, 2023 •
edited
Loading

Move import of SparkSession to file begin, to fix the missing type problem of spark_session.

@Aries-ckt
Copy link
Collaborator

Move import of SparkSession to file begin, to fix the missing type problem of spark_session.

It would be to use lazy import for the users who do not use Spark.

@fangyinc fangyinc added the invalid This doesn't seem right label Nov 30, 2023
@csunny
Copy link
Collaborator

csunny commented Dec 1, 2023

Thanks, this way of writing does not meet our requirements

@csunny csunny closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dl-sdu @Aries-ckt @csunny @fangyinc