bugfix: doris icon broken #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change mysqlclient version for using pydoris on python 3.10+ env
|
after #902 , found the icon wasn't fixed yet, as the frontend code got added to repo, so made this fix. |
csunny
approved these changes
Dec 18, 2023
vshy108
pushed a commit
to vshy108/DB-GPT
that referenced
this pull request
Jan 18, 2024
Co-authored-by: 一帆 <[email protected]>
Hopshine
pushed a commit
to Hopshine/DB-GPT
that referenced
this pull request
Sep 10, 2024
Co-authored-by: 一帆 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 2 bugs
1、doris icon broken （need run
scripts/build_web_static.shafter merge)2、change mysqlclient version for using pydoris on python 3.10+ env, see PyMySQL/mysqlclient#639, it cause lot of effert to fix the pkg-config and mysql env which is unnecessary for current features.