Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvement and bugfixes for the colorimeter correction workflow #469

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ethanbrookins
Copy link

@ethanbrookins ethanbrookins commented Dec 15, 2024

  1. Bugfix: If only a spectrometer is currently connected, when check_last_ccxx_ti3 runs for the second time to check the colorimeter .ti3, it no longer throws an error since the colorimeter file doesn't contain spectral data. Found this while working away from my desk, without a USB hub, and swapping between instruments.
  2. Bugfix: While looking through check_last_ccxx_ti3, I noticed that the instrument names never matched. It just needed to be decoded and now the little green checkmark will display properly.
  3. Improvement: Both .ti3 path dropdowns now properly select and show the most recent file when the window is opened. This had really bugged me for a while as a UX problem. Both would show as empty and blank when the window opens, even though the files were programmatically selected. The "Create colorimeter correction..." button would be enabled too, but at first glance, the user could not tell why or what would be used to create a correction if clicked. Also, after taking a new measurement, the user would not be shown that the new measurement was being applied. Now the most recent files are clearly shown, which makes the process more apparent to the user. Note that using wx.CallAfter does mean the dropdowns show as blank for a split second in the GUI before the filenames are loaded, but I think this is definitely worth the UX improvement. (This took me forever to find and figure out to fix, but I'm so glad I did haha.)
  4. Bugfix: The white luminance values from both .ti3 files are now properly decoded. This means the xyY and dE values that DisplayCal shows in the GUI as the last step of the correction process and then writes to the metadata of the .ccmx file are correct and accurate to the measured values from both instruments. I confirmed that this does not affect the actual correction matrix, as that is created directly by Argyll ccmxmake. So any corrections created before this was fixed are still accurate. Just the dE metadata would have been inaccurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant