Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix modals outside click (Issue #2578) #2656

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Nov 22, 2024

Description:

Fix outside click for modals
In code editor add minimise function to esc button

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the bug Something isn't working label Nov 22, 2024
@Derikyan Derikyan self-assigned this Nov 22, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 22, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2656.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 25, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2656.nightly-test.deltixhub.io
E2E tests status: failed

@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 25, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2656.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan
Copy link
Contributor Author

Derikyan commented Nov 26, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2656.nightly-test.deltixhub.io
E2E tests status: failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants