Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modulify-ui): library updates #2787

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

sergesha
Copy link
Contributor

Description:

  1. Update the modulify-ui library:
  • Each method in ComponentBuilder can only be executed once; add a check for this.
  • Pre-render JSS styles on the server; add wrappers in _app.tsx and _document.tsx.
  1. Update the patch file:
  • Fix RxJs error.
  • Enable server-side debugging in Next.js.
  1. Apply modulify-ui to the most sought-after components for customization.

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@sergesha sergesha force-pushed the feature/modulify-ui-updates branch from 0951cdc to 47428a0 Compare December 16, 2024 10:54
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Dec 16, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2787.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor

denys-kolomiitsev commented Dec 23, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2787.nightly-test.deltixhub.io
E2E tests status:


const SERVER_SIDE_JSS_STYLES_ID = 'server-side-jss-styles';

type DocumentWithInitialProps = ComponentType<any> & {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be good either to specify different type if it possible or to disable lint rule for this line.
This will fix style_checks error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants