Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): add error boundary for invalid form schema (Issue #2901) #2904

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Jan 5, 2025

Description:

  • add error boundary component
  • add highlighting for selected button in edit mode
  • pass disable edit flag down to desktop message component

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir Gimir added bug Something isn't working _priority_1 labels Jan 5, 2025
@Gimir Gimir self-assigned this Jan 5, 2025
@Gimir
Copy link
Contributor Author

Gimir commented Jan 5, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2904.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir enabled auto-merge (squash) January 5, 2025 20:26
@Gimir
Copy link
Contributor Author

Gimir commented Jan 6, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2904.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir merged commit 3b748fd into development Jan 7, 2025
9 checks passed
@Gimir Gimir deleted the fix/2901-incorrect-schema branch January 7, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _priority_1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants