Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMGCIP-164: Implement Footer #38

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Conversation

gordoney
Copy link
Collaborator

@gordoney gordoney commented Dec 26, 2024

Ticket

https://jira.epam.com/jira/browse/EPMGCIP-164

Preview

https://676d74de2c3980dfbbcbc4ef--staging-savitsky-museum.netlify.app/en

Code changes

  • Implemented Footer component with social networks
  • Added CircleLink component for rendering styled links
  • Added unit tests
  • Added @tabler/icons-react dependency containing icons as for EPMGCIP-163
Recording.2024-12-26.192321.mp4

@gordoney gordoney changed the title Feature/epmgcip 164/implement footer EPMGCIP-164: Implement Footer Dec 26, 2024
Copy link
Collaborator

@Dzmitry-Yaniuk Dzmitry-Yaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Please, address to some comments

src/components/atoms/CircleLink/CircleLink.tsx Outdated Show resolved Hide resolved
src/components/organisms/Footer/Footer.tsx Outdated Show resolved Hide resolved
src/components/organisms/Footer/Footer.test.tsx Outdated Show resolved Hide resolved
@gordoney gordoney merged commit 106ada9 into main Jan 8, 2025
1 check passed
@gordoney gordoney deleted the feature/EPMGCIP-164/implement-footer branch January 8, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants