Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMGCIP-181: Fix test warnings #40

Merged
merged 4 commits into from
Jan 8, 2025
Merged

EPMGCIP-181: Fix test warnings #40

merged 4 commits into from
Jan 8, 2025

Conversation

Dzmitry-Yaniuk
Copy link
Collaborator

https://jira.epam.com/jira/browse/EPMGCIP-181

Code changes

  • Resolved all warnings and bad setup steps in ContactForm component;
  • Extended contact-form component for better testing with data-testid attributes;
  • Added wrapper util Logger to suppress all application output errors in test console, updated usage across app;
  • Extended ESLint configuration rule from 200 to 250 symbols due to limit in ImageGallery;
  • Added updated value for DEBUG_PRINT_LIMIT with limit amount for 15000 symbols;

Copy link
Collaborator

@gordoney gordoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, thank you!

@Dzmitry-Yaniuk Dzmitry-Yaniuk merged commit 68efd62 into main Jan 8, 2025
1 check passed
@Dzmitry-Yaniuk Dzmitry-Yaniuk deleted the feature/EPMGCIP-181 branch January 8, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants