Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/epmgcip 166/migrate old pages #42

Merged
merged 17 commits into from
Feb 5, 2025

Conversation

gordoney
Copy link
Collaborator

@gordoney gordoney commented Jan 24, 2025

https://jira.epam.com/jira/browse/EPMGCIP-166

Code changes

  • Added styles for content pages
  • Fixed issue with eslint ignored files
  • Updated graphql requests for new Page model
  • Added new Page component for rendering simple pages
  • Added pages for migration and adjusted routes
  • Added possibility to render images from rich text editor
  • Made root menu links lead to a pages
  • Wrote tests

Notes

  • SLUGS was added in order to avoid getting slug from headers. Netlify has issues related to dynamic headers, so this approach was used as workaround.

Pages

https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/museum
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/museum/history
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/museum/restoration-section
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/museum/projects
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/museum/library
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/museum/book-shop
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/exposition
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/exposition/archaeology
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/exposition/folk-applied-art
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/exposition/gallery
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/visits
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/friends
https://6793a7746593b03472ec1d8c--staging-savitsky-museum.netlify.app/en/contacts

@gordoney gordoney force-pushed the feature/EPMGCIP-166/Migrate-old-pages branch from af3e370 to a08fe32 Compare January 24, 2025 14:25
Copy link
Collaborator

@Dzmitry-Yaniuk Dzmitry-Yaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Please, address to some comments

.eslintrc.json Outdated Show resolved Hide resolved
src/components/atoms/Title/Title.tsx Show resolved Hide resolved
src/components/organisms/Header/Header.tsx Outdated Show resolved Hide resolved
src/components/organisms/Header/Header.tsx Show resolved Hide resolved
src/lib/page.ts Outdated Show resolved Hide resolved
src/middleware.ts Outdated Show resolved Hide resolved
@gordoney gordoney merged commit ee8495f into main Feb 5, 2025
1 check passed
@gordoney gordoney deleted the feature/EPMGCIP-166/Migrate-old-pages branch February 5, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants