-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webapp/TrainingInformation: fix graph jumps #696
Conversation
bbd631c
to
dd95f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great it's much less shaky now!
Though it used to be even smoother, the animations looked perfectly smooth at commit *: rework packages names:
Screen.Recording.2024-07-09.at.15.21.16.mov
And right now it looks like that:
Screen.Recording.2024-07-11.at.14.26.39.mov
I tried to rollback the previous apexcharts and vue3-apexcharts minor versions but it didn't change the animations so I guess it's on our side.
It would be nice to have the smoother animations but we can merge this as it is if you want!
dd95f32
to
5257b03
Compare
soo, we are hitting a strange case here, where the updates are faster than the chart's animations. in the first case, it takes ~1.2s to get the next value, in the second, it's ~1s, and the animation itself is timed for 1s.
I added a commit to use the default animation speed (350ms) to avoid that. it makes the training look a bit ~faster. on the graphs in general: I think that we can rethink what is shown in the training informations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great it looks perfect! Nicely done this must have been hard to figure out.
|
when moving from the end of a round to a new one, the serie is computed twice (with the same results). that stops the animations in the graphs. fixing it by returning the oldValue (which is checked via
===
in Vue) to stop changes propagation.Closes #695