Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to UserProfileListView #1038

Merged
merged 25 commits into from
Sep 1, 2023
Merged

Add filter to UserProfileListView #1038

merged 25 commits into from
Sep 1, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Aug 28, 2023 •
edited
Loading

requires #1037 for checks to complete

closes #1027
closes #392

  • qualifications filter
  • use grants_to_essential_abbreviations in other places
  • left align the labels on lg?
  • check performance (no 1+n queries)
  • add info to group list: permissions, members?
  • tests for the view and its filter
  • fix TODOs and FIXMEs
  • consider select2 bootstrap5 theme not working #860

@felixrindt felixrindt added [C] feature New feature or request [C] design/ui Enhancement of existing views labels Aug 28, 2023
@felixrindt felixrindt modified the milestone: Dennis Aug 28, 2023
@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited
Loading

Coverage Status

coverage: 89.398% (+0.3%) from 89.089% when pulling 148a59d on better-user-group-lists into 0c089b0 on main.

@felixrindt felixrindt marked this pull request as draft August 28, 2023 14:09
@felixrindt felixrindt marked this pull request as ready for review August 30, 2023 18:30
@felixrindt felixrindt requested a review from jeriox August 30, 2023 18:31
@felixrindt felixrindt force-pushed the better-user-group-lists branch 3 times, most recently from 67063b9 to 2c99aeb Compare August 31, 2023 19:43
jeriox
jeriox requested changes Aug 31, 2023
View reviewed changes
ephios/core/signup/participants.py Outdated Show resolved Hide resolved
ephios/plugins/basesignup/templates/basesignup/participation_card_inline.html Show resolved Hide resolved
ephios/core/templates/core/group_list.html Show resolved Hide resolved
ephios/core/templates/core/group_list.html Show resolved Hide resolved
ephios/core/templates/core/userprofile_list.html Outdated Show resolved Hide resolved
ephios/core/templates/core/userprofile_list.html Outdated Show resolved Hide resolved
ephios/core/templates/core/userprofile_list.html Outdated Show resolved Hide resolved
@felixrindt felixrindt enabled auto-merge (rebase) September 1, 2023 14:45
@felixrindt felixrindt enabled auto-merge (squash) September 1, 2023 14:45
@felixrindt felixrindt merged commit 567ae17 into main Sep 1, 2023
18 checks passed
@felixrindt felixrindt deleted the better-user-group-lists branch September 1, 2023 14:50
@jeriox jeriox mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
[C] design/ui Enhancement of existing views [C] feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display number of user account in user list view + paginate Userlist too wide
3 participants
@felixrindt @coveralls @jeriox