Skip to content

Commit

Permalink
fix remaining tests
Browse files Browse the repository at this point in the history
  • Loading branch information
gilesknap committed Jun 13, 2024
1 parent 14d2ef5 commit 0a90f07
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/ibek/entity_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def add_arg(name, typ, description, default):
else:
# arg.type is str, int, float, etc.
type = getattr(builtins, arg.type)
add_arg(name, type, arg.description, getattr(arg, "default"))
add_arg(name, type, arg.description, getattr(arg, "default")) # type: ignore

# add in the calculated values Jinja Templates as Fields in the Entity
add_defines(definition.post_defines)
Expand Down
1 change: 0 additions & 1 deletion tests/test_support.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def test_symlink_ibek(tmp_path: Path, samples: Path):
"ADCore.ibek.support.yaml",
"asyn.ibek.support.yaml",
"bad_db.ibek.support.yaml",
"dlsPLC.ibek.support.yaml",
"epics.ibek.support.yaml",
"fastVacuum.ibek.support.yaml",
"gauges.ibek.support.yaml",
Expand Down
5 changes: 2 additions & 3 deletions tests/test_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import jinja2
import pytest
from ruamel.yaml.main import YAML

from ibek.commands import semver_compare
from ibek.ioc import id_to_entity
Expand All @@ -26,12 +25,12 @@ def test_object_references(entity_factory):
EntityDefinition(
name="port",
description="a port",
params=[IdParam(name="name", description="an id")],
params={"name": IdParam(description="an id")},
),
EntityDefinition(
name="device",
description="a device",
params=[ObjectParam(name="port", description="the port")],
params={"port": ObjectParam(description="the port")},
),
],
)
Expand Down

0 comments on commit 0a90f07

Please sign in to comment.