Adding ads driver support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaget
force-pushed
the
feat-add-ads-support
branch
2 times, most recently
from
03e55fb
to
b805579
Compare
|
Looks good, thanks! Is there any way to have an automated test for this support module? |
Probably one day with that https://pyads.readthedocs.io/en/latest/documentation/testserver.html find by @minijackson, (I'm not sure you know him). But not in a near future due to my schedule |
minijackson
reviewed
Apr 9, 2024
minijackson
reviewed
Apr 9, 2024
agaget
force-pushed
the
feat-add-ads-support
branch
2 times, most recently
from
455b233
to
0cdf9b0
Compare
agaget
force-pushed
the
feat-add-ads-support
branch
from
0cdf9b0
to
abc9a0a
Compare
minijackson
added
the
backport nixos-23.11
|
Successfully created backport PR for |
minijackson
added
the
backport nixos-23.05
|
Git push to origin failed for nixos-23.11 with exitcode 1 |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESS ADS driver for Beckhoff TwinCAT communication.
https://gitlab.esss.lu.se/epics-modules/epics-twincat-ads