Use new base 32 encode and decode #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Aug 28, 2024
|
Whoops, looks like this broke TypeScript. Could you look into that please? The automated release can't go out until that's fixed. |
|
@kentcdodds can you point me to the issue? I don't see any support for type checking in the scripts... |
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #8
This package is used by remix-auth-totp package which is breaking when deployed to aws lambda using sst.
The proposed fix in this PR was tested inside the project where I was experiencing the issue. I had to alter the tests slightly to make them work. Not sure if these changes imply any breaking changes.
Related issue in remix-auth-totp: dev-xo/remix-auth-totp#69
Related PR in remix-auth-totp: dev-xo/remix-auth-totp#70