Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better connect setting up and addressing code reviews #84

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

joshwlambert
Copy link
Member

This PR addresses #83 by adding some text to the end of both the Partial review and Full package review sections to link them to the Addressing package reviews section.

This PR also updates the hyperlink to the lintr workflow as this is no longer in the epiverse-trace/workflows/ repository, and is now in the epiverse-trace/packagetemplate/ repository; and updates any instances of "Github" with "GitHub" in the code review chapter.

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for playful-gelato-7892ba ready!

Name Link
🔨 Latest commit 1a01586
🔍 Latest deploy log https://app.netlify.com/sites/playful-gelato-7892ba/deploys/65dda18b8561b900081fd705
😎 Deploy Preview https://deploy-preview-84--playful-gelato-7892ba.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the added line fulfils the required clarification. for me, this is ready to merge 🚀

code-review.qmd Outdated Show resolved Hide resolved
@joshwlambert
Copy link
Member Author

@Bisaloo & @chartgerink, both @avallecam and I are happy with the changes in this PR, please merge at your earliest convenience.

code-review.qmd Outdated Show resolved Hide resolved
code-review.qmd Outdated Show resolved Hide resolved
@chartgerink chartgerink merged commit 056101a into main Feb 27, 2024
@chartgerink chartgerink deleted the updt_code_rev branch February 27, 2024 08:47
@joshwlambert
Copy link
Member Author

@chartgerink thanks for spotting and changing the links, I'd forgotten to make them relative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants