-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better connect setting up and addressing code reviews #84
Conversation
✅ Deploy Preview for playful-gelato-7892ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the added line fulfils the required clarification. for me, this is ready to merge 🚀
@Bisaloo & @chartgerink, both @avallecam and I are happy with the changes in this PR, please merge at your earliest convenience. |
@chartgerink thanks for spotting and changing the links, I'd forgotten to make them relative. |
This PR addresses #83 by adding some text to the end of both the Partial review and Full package review sections to link them to the Addressing package reviews section.
This PR also updates the hyperlink to the lintr workflow as this is no longer in the
epiverse-trace/workflows/
repository, and is now in theepiverse-trace/packagetemplate/
repository; and updates any instances of "Github" with "GitHub" in the code review chapter.