Review karim

[Karim-Mane]

@jamesmbaazam below are some comments, suggetions and actions from the review I performed

1. I noticed that some files names are .r and others are .R. Is there any specific reason for this? If not, maybe consider harmonising the file naming.

2. I have updated the .lintr file by copy-pasting from package template

3. the example from the simulate_summary() function returns a vector of Inf values. Is this intentional? If yes, would not it be more informative to provide an example that returns actual data?

4. The example from the likelihood() function is not working. This is because the chains_likelihood list only contains Inf values. Maybe consider using a different example.

5. In borel.r:

   • no examples for the exported functions
   • you are using return() in the other functions but not in rborel(). Consider harmonising on return().

[jamesmbaazam]

Thanks for the review, Karim. I have made several changes from #121 including ones that intersect with your comments. I will link the issues and PR's in my replies below and close this PR. You will be added as a reviewer when #198 is closed.

@jamesmbaazam below are some comments, suggetions and actions from the review I performed

1. I noticed that some files names are .r and others are .R. Is there any specific reason for this? If not, maybe consider harmonising the file naming.

No, there is no reason. I most of the files with .r are legacy files and the newer ones one .R extension. I will fix this in #135.

2. I have updated the .lintr file by copy-pasting from package template

Thanks for this. I have already fixed it in #180.

3. the example from the simulate_summary() function returns a vector of Inf values. Is this intentional? If yes, would not it be more informative to provide an example that returns actual data?

Indeed, it will be more informative. I will fix it in #150 and #151.

4. The example from the likelihood() function is not working. This is because the chains_likelihood list only contains Inf values. Maybe consider using a different example.

Thanks. This has been fixed in main.

5. In borel.r:

• no examples for the exported functions
  Thanks. I will fix this in Add examples to exported class constructors #160.

• you are using return() in the other functions but not in rborel(). Consider harmonising on return().

I have merged a PR that ensures that all functions have explicit returns. See #190.