-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove simulate_tree()
and simulate_tree_from_pop()
and replace usage with simulate_chains()
#182
Conversation
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 99.26% 99.41% +0.15%
==========================================
Files 8 8
Lines 682 517 -165
==========================================
- Hits 677 514 -163
+ Misses 5 3 -2 ☔ View full report in Codecov by Sentry. |
9500df1
to
8402fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also closes #158 |
Ah sorry yes that makes sense |
This PR closes #181 by:
simulate_tree()
andsimulate_tree_from_pop()
,simulate_chains()
in tests, vignettes, and examples.Additionally, where necessary, descriptions involving
simulate_tree()
andsimulate_tree_from_pop()
have been rephrased. Examples include the README (64015e1) and Getting Started vignettes (e38453a).