Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ntrees argument to index_cases to clarify meaning #187

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

jamesmbaazam
Copy link
Member

This PR renames the ntrees argument to index_cases to help clarify the review comment in #158. The PR closes #158 and closes #186.

@jamesmbaazam jamesmbaazam added documentation Improvements or additions to documentation refactoring labels Jan 26, 2024
@jamesmbaazam jamesmbaazam added this to the v0.1.0 milestone Jan 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9285cb0) 99.41% compared to head (11fd842) 99.41%.

❗ Current head 11fd842 differs from pull request most recent head 4d17f88. Consider uploading reports for the commit 4d17f88 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files           8        8           
  Lines         517      517           
=======================================
  Hits          514      514           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesmbaazam jamesmbaazam merged commit 72b23d4 into main Jan 26, 2024
8 checks passed
@jamesmbaazam jamesmbaazam deleted the rename-ntrees branch January 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename ntrees in simulate_summary() to index_cases Clarify documentation of ntrees
2 participants