Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to helper/checker functions #192

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

jamesmbaazam
Copy link
Member

This PR closes #157 by:

  • Using switch() instead of ifelse() ladders for doing choice operations
  • Prefixes all internal helper and checker functions with a . to align with other Epiverse-TRACE packages, e.g., superspreading, simulist, and epidemics. This is mostly for visual effects and to prevent (rare) NAMESPACE clashes.

Bullet 3 in the linked issue is solved by abstracting away the suggested change with the function update_chain_stat(), which now uses switch().

@jamesmbaazam jamesmbaazam added this to the v0.1.0 milestone Jan 29, 2024
@jamesmbaazam jamesmbaazam changed the title Use dot prefix for internal helper functions Minor improvements to helper/checker functions Jan 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@0941451). Click here to learn what that means.

❗ Current head 300f03f differs from pull request most recent head d642146. Consider uploading reports for the commit d642146 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage        ?   99.43%           
=======================================
  Files           ?        8           
  Lines           ?      529           
  Branches        ?        0           
=======================================
  Hits            ?      526           
  Misses          ?        3           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesmbaazam jamesmbaazam merged commit f50d447 into main Jan 30, 2024
8 checks passed
@jamesmbaazam jamesmbaazam deleted the improve-helper-funcs branch January 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve helper functions
2 participants