-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulate_summary()
: Enhance to track finite populations & improve documentation
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jan 29, 2024
jamesmbaazam
changed the title
Make the subsection a section
Jan 29, 2024
simulate_summary()
: Enhance to track finite populations & improve documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 99.43% 99.45% +0.02%
==========================================
Files 8 8
Lines 529 550 +21
==========================================
+ Hits 526 547 +21
Misses 3 3 ☔ View full report in Codecov by Sentry. |
sbfnk
force-pushed
the
simulate-summary-with-pop
branch
from
January 30, 2024 12:00
1b7ad5f
to
80cec06
Compare
sbfnk
reviewed
Jan 30, 2024
To aid fine-grained reuse and inheritance in other functions
jamesmbaazam
force-pushed
the
simulate-summary-with-pop
branch
from
January 30, 2024 16:26
80cec06
to
1efef50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEWS.md
simulate_summary()
to handle finite populationssimulate_chains()
, a section to explain the difference betweensimulate_summary()
andsimulte_chains()
, improved examples, a details section.simulate_chains()
, so it has been removed.Simulates a vector of transmission chains assuming an infinite population
Simulates a vector of transmission chains with the ability to limit the outbreak to a finite population size
Maybe. The function arguments have been re-arranged and the dots argument has been moved in front of the optional arguments to ensure that the optional arguments are properly specified and to avoid accidental positional matching of arguments.
simulate_summary()
to deal with finite populations #178.simulate_chains()
was changed to a section to ensure that it was not inherited in the process of reusing other sections insimulate_summary()
.