-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create landing page for training materials #157
Conversation
✅ Deploy Preview for tourmaline-marshmallow-241b40 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b1204c2
to
911cd6a
Compare
844669f
to
f777328
Compare
46c9e34
to
5803421
Compare
@Bisaloo - this is ready for a review as well - but given that you opened the PR I can't request you directly :-) https://deploy-preview-157--tourmaline-marshmallow-241b40.netlify.app/learn |
Thank you, @chartgerink @Bisaloo for working on this. Here is some initial feedback that I'm happy to discuss and find alternatives.
I have the (possibly biased) idea that a listing format like the one used in the howto index site (here qmd file) could open the possibility of sections with the listing within each section. To keep the visuals, instead of @rozeggo input on this issue will also be helpful. |
Hi Chris/Hugo. This looks nice but the grid listing may be hard to categorise/order the lessons? Maybe I am misunderstanding a little bit the plan, but I thought we were aiming for a layout like this: https://software-carpentry.org/lessons/ |
Thanks for the feedback @rozeggo and @avallecam! As far as I can tell, there was no scope document available so I was unaware of these requirements. Are there any additional things I need to be aware of before working on this? |
Had a chat with @avallecam about this and we found a way forward. Reverted this pull request to draft until it's in a ready state again. |
@avallecam, to be sure before @chartgerink spends more time on this: does the proposed format support non-sandpaper lessons, such as the e-Epi-Training Kit Laura is developing? |
@Bisaloo thank you for your question. the proposed format will include non-sandpaper materials in isolated tables (refer to the preliminary Google Doc draft document) per type of material: e-learning platform, tutorials, how-to guides, and case studies, so the number of columns between the name and the dev-stage can vary depending on the each. |
for homogeneity across isolated tables, we can take the approach used by galaxy (link to reference) |
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
This PR is now ready for review and will stay open for a week or so. Please add anyone who needs to be consulted on this PR. It's been through several iterations now so please focus on details over fundamental changes. |
thanks @chartgerink for opening this PR. @Bisaloo @lgbermeo could we have your review for this during the next week? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone for your work on this! I can't officially approve since I opened this PR but ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with how this page is displayed. My main interest now is about the cellphone display and how appropriate is the naming of the research software curriculum
. I'm open to read your alternatives.
|
||
### Tutorials in English | ||
|
||
| Tutorial | Site | Repository | Instructor Schedule | Development stage | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at how this looks on the cellphone (Please, see attached screenshot), I'm interested in finding ways to increase the width of the name column.
I think:
- one could be to change the column name of the last column from
Development stage
toStage
. Any strong opinion on this? - other, to combine the name and site columns, linking them directly in the name, as previously tested by @chartgerink in this PR.
Also, we may have an increase benefit mixing both alternatives. Here I'm proposing the first one:
| Tutorial | Site | Repository | Instructor Schedule | Development stage | | |
| Tutorial | Site | Repository | Instructor Schedule | Stage | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avallecam please provide final input for the tables. I have changed them back and forth several times already, so in order to prevent any further issues, I will await your specific instructions for the final revision as part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding feedback from @lgbermeo
Co-authored-by: Hugo Gruson <[email protected]>
Co-authored-by: Hugo Gruson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated in #157 (comment) I agree with the final table outlook. The cellphone format currently provides full words per line and looks more readable. For me, this is ready to merge 🚀
8cfceaf
to
980265f
Compare
R
Right before merging:
date
field has been updatedblueprints
to link to this post_freeze/
folder is up-to-date