Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions workflows #99

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Update actions workflows #99

merged 1 commit into from
Feb 25, 2025

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Feb 25, 2025

Fix #98

Latest version for these two actions as of today is v3

@jamesmbaazam
Copy link
Member

I think v3 is deprecated in favour of v4.

Moreover, should all this not be managed by the dependabot workflow?

@Bisaloo
Copy link
Member Author

Bisaloo commented Feb 25, 2025

v3 is indeed the latest version: https://github.com/actions/upload-pages-artifact/releases/tag/v3.0.1

You're thinking of another action.

Yes, we could potentially set up dependabot, with the caveat that dependabot PRs should not be merged without checking for potential breaking changes so in practice, I find the benefit is minimal after having used both systems. I don't feel super strongly and I'm happy to leave this up to the repo's maintainer.

@jamesmbaazam
Copy link
Member

Ah, my bad! I read it as actions/upload-artifacts.

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the edit @Bisaloo I'll merge it 🚀 and evaluate how the other PR reacts

@avallecam avallecam merged commit 2e82288 into main Feb 25, 2025
2 checks passed
@avallecam avallecam deleted the Bisaloo-patch-1 branch February 25, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload artifact deprecated
3 participants