Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .github/settings.yml #145

Merged
merged 3 commits into from
Apr 22, 2024
+22 −0
Merged

Add .github/settings.yml #145

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
006dbf0
Add `.github/settings.yml`
chartgerink Apr 18, 2024
5d4859b
Update settings
chartgerink Apr 18, 2024
6856d01
Comment out values
chartgerink Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
repository:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if we can also set the GitHub Pages settings in accordance with our pkgdown workflow. Let's keep an eye on repository-settings/app#609.

# https://probot.github.io/apps/settings/
allow_merge_commit: false
allow_rebase_merge: true
allow_squash_merge: true
default_branch: main
delete_branch_on_merge: true
has_discussions: false
has_issues: true
has_projects: false
has_wiki: false
private: false
chartgerink marked this conversation as resolved.
Show resolved Hide resolved
branches:
- name: main
# https://docs.github.com/en/rest/reference/repos#update-branch-protection
protection:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:
We have discussed using required_linear_history: true with @bahadzie in the past but didn't come up with a satisfying solution.
The problem is that it will not remove the button "update branch" (implied: with a merge commit), but then block you from merging the PR is you clicked this button.

required_pull_request_reviews:
required_approving_review_count: 1 # (1-6)
chartgerink marked this conversation as resolved.
Show resolved Hide resolved
dismiss_stale_reviews: true
require_code_owner_reviews: false
required_status_checks:
strict: true