89 refac summary methods #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joshwlambert
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for addressing the comment I made in the full package review @davidsantiagoquevedo. I've left a few comments in the diffs. Please let me know if any of my comments are unclear and I'm happy to discuss and clarify.
|
Hi @joshwlambert. Thanks for your review. I addressed all the comments. Please, let me know if you have further suggestions. |
joshwlambert
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR answering issue #89
Main changes
summary.match()method sincematch_cohortis not intended to be used externally and it already returns the necessary outputs to feed othersummarymethodssummary.vaccineff_data()and addedprint.summary.vaccineff_data()summary.vaccineffand addedprint.summary.vaccineff()