Fix 38 age interval get age group #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed option to set interval '<min_val' when min_val<0
…l)%%step!=0. Added test for min_val>0
…ed documentation of the function
4 tasks
GeraldineGomez
approved these changes
Feb 21, 2024
…bers. Removed upper check for min_val to avoid redundancy with lower check for max_mal
davidsantiagoquevedo
added a commit
that referenced
this pull request
Mar 13, 2024
* feat: match function * refac: added MatchtIt to Description * feat: documentation, removed in output. Changed name of function * roxygen: generate documentation match_cohort * feat: added basic estructure of function to censore matches * Fix 38 age interval get age group (#43) * fix: definition of age interval when (max_val-min_val)%%setp !=0. Added option to set interval '<min_val' when min_val<0 * refac: removed test forcing interval '>max_val', when (max_val-min_val)%%step!=0. Added test for min_val>0 * refac: step=10 on PH-accept test * feat: pulled description from previous PR * feat: warning for module of interval by step different to zero. Updated documentation of the function * simplified tests to control warning * roxygen: description of warning and lower value * fix: assert_number replaced by assert_integerish * fix: upper = max_val for assertion on min_val * style: documentation * fix: warning message for (max-min)%%step!=0 * roxygen: automatic update * fix: assert_integerish replaced by assert_int, better for integer numbers. Removed upper check for min_val to avoid redundancy with lower check for max_mal * fix: example in documentation * feat: test for non-integer values * refac: simplified workflow of match_cohort. Set method = nearest by default and ratio = 1 in matchit * fix: documentation reflecting changes in match_cohort() * roxygen: refac match_cohort * feat: documentation censore_match * roxygen: documentation censore_cohort * fix: example in documentation of both functions and column selection excluding weights to pass gp() * roxygen: fixed examples * feat: test for basic expectations and minimum censoring date * fix: return ordered datetype column matching with order of data frame * fix: test for minimum values. Added test for datetype * feat: tests for match_cohort * added MatchIt to wordlist * refac: replaced 'censore' by 'censor'. This misspelling had propagated throughout all the new functions * removed duplicated test * refac: added control for censoring date of matches. No censoring if member of couple presents outcome before censoring date * feat: test for outcome date before censoring date * sytle: lintr line 73 * roxygen: changes in documentation by adding outcome_date_col to params * feat: input checks censor_match * refac: censor_match() renamed as get_censoring_date_match * refac: removed caliper from input. receives it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
get_age_group()responding to issue #38. Main changes:stepfrommin_valtomax_val.(max_val- min_val)%%setp != 0, a warning is returned and the function uses the closest lower value to [max_valthat satisfies the condition.min_val !=0the ages lower thanmin_valare grouped in the interval<min_valget_age_group()responding to its new characteristicscoh_test_noconf