Abstract sending email, to allow for other email services #11
Conversation
mykeels
commented
Aug 10, 2021
mykeels
commented
- mailgun
- sendgrid
|
Someone is attempting to deploy a commit to a Personal Account owned by @epleaner on Vercel. @epleaner first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/epleaner/emotions-wheel/DUJALNzt3SCvUczgJSuHAGz4TxMH |
| const emailFrom = process.env.MAIL_FROM; | ||
| const url = process.env.MAIL_HOST_URL; | ||
|
|
||
| const ignore = async () => { |
There was a problem hiding this comment.
This fn does not need to be async
| const ignore = async () => { | ||
| console.warn("Unrecognized mail service", service); | ||
| }; | ||
| return ( |
| const params = { | ||
| from: emailFrom, | ||
| ...options, | ||
| ...(options.dynamic_template_data |
There was a problem hiding this comment.
I personally find this destructuring ternary pattern quite unreadable
| sgMail.setApiKey(apiKey); | ||
| return sgMail.send({ from: emailFrom, ...options }); | ||
| }, | ||
| }[service && service.toLowerCase()] || ignore |
| import crypto from 'crypto'; | ||
| import { hoursFromNow } from '@helpers/apiHelpers'; | ||
| import normalizeEmail from 'validator/lib/normalizeEmail'; | ||
|
|
||
| sgMail.setApiKey(process.env.SENDGRID_API_KEY); | ||
| import { sendEmail } from './sendEmail'; |
| import crypto from 'crypto'; | ||
| import nextConnect from 'next-connect'; | ||
|
|
||
| import database from '@middleware/database'; | ||
| import { minutesFromNow } from '@helpers/apiHelpers'; | ||
|
|
||
| sgMail.setApiKey(process.env.SENDGRID_API_KEY); | ||
| import { sendEmail } from '../../../../helpers/apiHelpers/sendEmail'; |
|
Hi @mykeels , thanks for contributing! Wondering why you closed this PR before it was reviewed and merged? |
