Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use placeholder attribute as accessible name #1046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ymrl
Copy link

@ymrl ymrl commented May 11, 2024

According to HTML-AAM, placeholder attribute will be used as accessible name if text-field elements (input element with some types or textarea element) do not have aria-label, aria-labelledby attributes, related label element, or title attribute.

So, I changed computeTextAlternative() function to use placeholder attribute. And to take priority for title attribute, changed to use title attribute before it.

Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: fea3a94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kkoo95
Copy link

kkoo95 commented Sep 11, 2024

are there plans to merge this PR soon ? w3c/accname is already supporting this but we are stuck with dom-accessibility-api because we are using testing-library :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants