Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oustide activity #174

Closed
wants to merge 10 commits into from

Conversation

Nitnelav
Copy link
Collaborator

There is an error when running a scenario cutter on top of a previous scenario cutter, the outside activity ids start from 1 again without checking the existence of previous ids in the scenario.
This patch fixes it

@Nitnelav
Copy link
Collaborator Author

I don't know why I keep having the AnalysisOutputListener part in my commits... did I really add that last year without commiting it ?

@sebhoerl
Copy link
Collaborator

sebhoerl commented Dec 14, 2023

Don't know, often when I do "partial contributions" from a branch that has already been merged partly in the past, I do something like that:

  • checkout target master (here develop) branch, pull latest version
  • checkout my_branch, make sure everything is clean
  • merge in master branch, resolve conflicts, to be sure the branches are compatible
  • then do git reset master which will only show all the files that have been changed wrt the current master
  • then I just pick the files that i want to commit now (and maybe others later) and the reset I just do git checkout master /file/that/i/dont/want/tocommityet
  • then I make a git branch new_branch, checkout new_branch and then make a commit which will solely contain the new files without any of my internal history, just mapping the new changes on top of the base master
  • then I send a PR from this new_branch

I have the feeling this is what some rebase cherrypicking may do automatically, but it works for me and makes sense for me step by step :D

@Nitnelav
Copy link
Collaborator Author

thanks I think I figured it out !

@Nitnelav Nitnelav closed this Dec 14, 2023
@Nitnelav Nitnelav deleted the fix_oustide_activity_id branch December 14, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants