Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that the outside activity id does not already exist #176

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Nitnelav
Copy link
Collaborator

There is an error when running a scenario cutter on top of a previous scenario cutter, the outside activity ids start from 1 again without checking the existence of previous ids in the scenario.
This patch fixes it

@Nitnelav Nitnelav changed the title ensure that the outside activity id does not already exist fix :ensure that the outside activity id does not already exist Dec 14, 2023
@Nitnelav Nitnelav changed the title fix :ensure that the outside activity id does not already exist fix: ensure that the outside activity id does not already exist Dec 14, 2023
@sebhoerl
Copy link
Collaborator

sebhoerl commented Dec 15, 2023

Nice! LGTM

Just add a line to the CHANGELOG please.

@Nitnelav Nitnelav enabled auto-merge (squash) December 15, 2023 20:03
@Nitnelav Nitnelav merged commit 401852e into eqasim-org:develop Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants