Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-stage taxi trip to SaoPauloTaxiPredictor #194

Merged
merged 3 commits into from
Feb 20, 2024
Merged

add multi-stage taxi trip to SaoPauloTaxiPredictor #194

merged 3 commits into from
Feb 20, 2024

Conversation

MayuriAnn
Copy link
Contributor

As suggested in #191 (comment), I followed the code on

for (Leg leg : TripStructureUtils.getLegs(elements)) {
if (leg.getMode().equals(TransportMode.car)) {
Verify.verify(!foundCar);
carTravelTime_min += leg.getTravelTime().seconds() / 60.0;
} else if (leg.getMode().equals(TransportMode.walk)) {
accessEgressTime_min += leg.getTravelTime().seconds() / 60.0;
} else {
throw new IllegalStateException("Unexpected mode in car chain: " + leg.getMode());
}
}
to update the code of SaoPauloTaxiPredictor class.

@balacmi balacmi self-requested a review February 19, 2024 07:51
Copy link
Contributor

@balacmi balacmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this. Can you please address my above comments and I will merge the PR.

@MayuriAnn
Copy link
Contributor Author

Please check if its correct now.

Copy link
Contributor

@balacmi balacmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@balacmi
Copy link
Contributor

balacmi commented Feb 20, 2024

May I also ask you to add to the CHANGELOG.md file the update you made, so we can keep track of what changed between releases.

@MayuriAnn
Copy link
Contributor Author

May I also ask you to add to the CHANGELOG.md file the update you made, so we can keep track of what changed between releases.

Done.

Copy link
Contributor

@balacmi balacmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@balacmi balacmi merged commit 9fab628 into eqasim-org:develop Feb 20, 2024
1 check passed
@MayuriAnn MayuriAnn deleted the multi-stage-taxi-sp branch February 20, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants