chore: update emissions codes to handle unknown Osm highway tag values #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitnelav
changed the title
|
Looks good, ready to merge? |
|
Yes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OsmHbefaMappingcode in matsim-libs throws a RuntimeException when the road type isn't found in map.We should write our own class for that at some point but then it could be contributed to matsim-libs directly.
In the mean time, the new class
SafeOsmHbefaMappingcatches the error and sets a default HBEFA road type.Probably Fixes eqasim-org/ile-de-france#213
Co-authored-by: @diallitoz