Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generalize pseudo random errors #290

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

sebhoerl
Copy link
Collaborator

First step towards resolving #280. Previously, estimators prefixed with epsilon_ magically obtained a pseudo-random errors term on top of the systematic utility. This process is now made explicit: To generate pseudo-random terms on top of per-trip utilities, one needs to set usePseudoRandomErrors to true in the eqasim config group.

@sebhoerl sebhoerl requested a review from tkchouaki January 20, 2025 16:53
Copy link
Collaborator

@tkchouaki tkchouaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebhoerl sebhoerl merged commit d4af27e into develop Jan 20, 2025
1 check passed
@sebhoerl sebhoerl deleted the feat/generalize-pseudo-random-errors branch January 20, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants