-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for any EMC2 HTS #292
base: develop
Are you sure you want to change the base?
Conversation
This is interesting as we (Tellae) are currently, but almost finished, connecting EQASIM to the last EMC² of Vendée. @MarieMcLaurent is doing this. |
Yes testing this with the EMC2 of Vendée would be great! I forgot to mention that my implementation is based on the Lyon implementation (ADISP). Only few changes are required to make it compatible with both EMC2 I tested. |
And here is the branch that contains an EMC2 implementation for Gironde: |
Let's see if they are 1:1 compatible. If not, I would propose to go, for the time being, with the existing pattern, like having a package ´emc2_gironde´, one ´emc2_vendee´ (if your two are 100% compatible, we can also just delegate the code from one to the other). For the documentation:
This is intentionally not the case for the HTS (because we don't want to filter the ENTD for a department where we only have very few observations), maybe it would be good to clarify this there. |
I tried to clarify that in the last commit. |
After quickly comparing with the EMC2 implementation of Gironde, I identified that:
|
I've compare this implementation with the one we used for the last EMC² of Vendée. |
Here is the code I wrote to use any EMC2 household travel survey (2018+) in the pipeline.
I have tested the code with the HTS for Brest and Chambéry. Further testing with other HTS might be required because I found a few things that are not well standardized:
MODES_MAP
(data/hts/cleaned.py
) might be incomplete.ZFM
column does not always match exactly with theZF
column in the geospatial data).I also slightly changed the README and added a documentation file to explain how to use the pipeline for any region.
I hope this can be useful!